Issue checkstyle#12486: NoWhitespaceAfter shouldn't check synchronize…

…d method
nrmancuso · Dec 2, 2022 · 68b724d · 68b724d
1 parent ae24c2f
commit 68b724d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceAfterCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceAfterCheck.java
@@ -286,8 +286,8 @@ private static boolean shouldCheckWhitespaceAfter(DetailAST ast) {
         final DetailAST previousSibling = ast.getPreviousSibling();
         final boolean isSynchronizedMethod = ast.getType() == TokenTypes.LITERAL_SYNCHRONIZED
                         && ast.getFirstChild() == null;
-        return (previousSibling == null || previousSibling.getType() != TokenTypes.ANNOTATIONS)
-                && !isSynchronizedMethod;
+        return !isSynchronizedMethod
+                && (previousSibling == null || previousSibling.getType() != TokenTypes.ANNOTATIONS);
     }
 
     /**

diff --git a/...st/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceAfterCheckTest.java b/...st/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceAfterCheckTest.java
@@ -354,15 +354,15 @@ public void testNoWhitespaceAfterWithEmoji() throws Exception {
                 getPath("InputNoWhitespaceAfterWithEmoji.java"), expected);
     }
 
-        @Test
+    @Test
     public void testNoWhitespaceAfterSynchronized() throws Exception {
-
         final String[] expected = {
             "18:9: " + getCheckMessage(MSG_KEY, "synchronized"),
         };
 
         verifyWithInlineConfigParser(
-                getPath("InputNoWhitespaceAfterSynchronized.java"), expected);
+                getPath("InputNoWhitespaceAfterSynchronized.java"),
+                expected);
     }
 
     /**