Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add content config option to allow a module to set own content #189

Merged
merged 2 commits into from Sep 15, 2022

Conversation

lukekarrys
Copy link
Member

@lukekarrys lukekarrys commented Sep 13, 2022

This also removes a lot of the redundant snapshot tests in favor of
testing the actual files written.

This also adds a few other features to allow npm/cli to use this in
the root workspace:

  • set npm and npx paths in workflows via config
  • dependabot now works with workspaces
  • templated files now include more partials which can be overwritten
    with content directory config
  • only file config options are merged between root and workspaces. this
    allows for the root to set config which will only apply to itself
  • workspace paths are ignored from linting and testing in the root, closes feat: scripts in workspace root should ignore workspaces #155

@lukekarrys lukekarrys changed the title wip feat: add content config option to allow a module to set own content Sep 14, 2022
@lukekarrys lukekarrys marked this pull request as ready for review September 14, 2022 08:19
@lukekarrys lukekarrys requested a review from a team as a code owner September 14, 2022 08:19
@lukekarrys
Copy link
Member Author

This is a preview of what the changes to npm/cli would look like if applied from this PR: npm/cli#5516

This also removes a lot of the redundant snapshot tests in favor of
testing the actual files written.

This also adds a few other features to allow `npm/cli` to use this in
the root workspace:

- set `npm` and `npx` paths in workflows via config
- dependabot now works with workspaces
- templated files now include more partials which can be overwritten
  with `content` directory config
- only file config options are merged between root and workspaces. this
  allows for the root to set config which will only apply to itself
- workspace paths are ignored from linting and testing in the root
This adds a `if: github.repository_owner == 'npm'` to each workflow so
they don't run outside of the npm organization by default.

Closes #182
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the example output for cli is helpful here. i have no concerns with these changes, it all looks pretty good to me!

@lukekarrys lukekarrys merged commit ffa2c08 into main Sep 15, 2022
@lukekarrys lukekarrys deleted the npm-cli branch September 15, 2022 17:24
@github-actions github-actions bot mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: scripts in workspace root should ignore workspaces
2 participants