Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install flags and ci cache #116

Merged
merged 2 commits into from
Mar 31, 2022
Merged

install flags and ci cache #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca2a591
feat: add audit and fund flags to install
lukekarrys Mar 30, 2022
d94fd52
feat: add lockfile option to control npmrc and ci cache
lukekarrys Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts --package-lock
- run: npm i --ignore-scripts --no-audit --no-fund --package-lock
- run: npm audit
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm run lint

test:
Expand Down Expand Up @@ -82,5 +82,5 @@ jobs:
if: ${{ !startsWith(matrix.node-version, '10.') }}
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm test --ignore-scripts
2 changes: 1 addition & 1 deletion .github/workflows/post-dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
gh pr checkout ${{ github.event.pull_request.number }}
npm install --ignore-scripts
npm install --ignore-scripts --no-audit --no-fund
npm run template-oss-apply
git add .
git commit -am "chore: postinstall for dependabot template-oss PR"
Expand Down
2 changes: 1 addition & 1 deletion lib/content/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ jobs:
steps:
{{> setupGit}}
{{> setupNode}}
- run: npm i --ignore-scripts --package-lock
- run: npm i --ignore-scripts --no-audit --no-fund --package-lock
- run: npm audit
4 changes: 2 additions & 2 deletions lib/content/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
steps:
{{> setupGit}}
{{> setupNode}}
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm run lint {{~#if isWorkspace}} -w {{pkgName}}{{/if}}

test:
Expand All @@ -55,5 +55,5 @@ jobs:
steps:
{{> setupGit}}
{{> setupNode useMatrix=true}}
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm test --ignore-scripts {{~#if isWorkspace}} -w {{pkgName}}{{/if}}
1 change: 1 addition & 0 deletions lib/content/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ module.exports = {
branches: ['main', 'latest'],
distPaths: ['bin/', 'lib/'],
ciVersions: ['12.13.0', '12.x', '14.15.0', '14.x', '16.0.0', '16.x'],
lockfile: false,
unwantedPackages: [
'eslint',
'eslint-plugin-node',
Expand Down
2 changes: 1 addition & 1 deletion lib/content/npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
package-lock=false
package-lock={{lockfile}}
2 changes: 1 addition & 1 deletion lib/content/post-dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
GITHUB_TOKEN: $\{{ secrets.GITHUB_TOKEN }}
run: |
gh pr checkout $\{{ github.event.pull_request.number }}
npm install --ignore-scripts
npm install --ignore-scripts --no-audit --no-fund
npm run template-oss-apply
git add .
git commit -am "chore: postinstall for dependabot template-oss PR"
Expand Down
3 changes: 3 additions & 0 deletions lib/content/setup-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
- uses: actions/setup-node@v3
with:
node-version: {{#if useMatrix}}$\{{ matrix.node-version }}{{else}}{{#each ciVersions}}{{#if @last}}{{.}}{{/if}}{{/each}}{{/if}}
{{#if lockfile}}
cache: npm
{{/if}}
{{#if useMatrix}}
- name: Update to workable npm (windows)
# node 12 and 14 ship with npm@6, which is known to fail when updating itself in windows
Expand Down
24 changes: 12 additions & 12 deletions tap-snapshots/test/apply/full-content.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts --package-lock
- run: npm i --ignore-scripts --no-audit --no-fund --package-lock
- run: npm audit

.github/workflows/ci.yml
Expand Down Expand Up @@ -190,7 +190,7 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm run lint

test:
Expand Down Expand Up @@ -242,7 +242,7 @@ jobs:
if: \${{ !startsWith(matrix.node-version, '10.') }}
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm test --ignore-scripts

.github/workflows/codeql-analysis.yml
Expand Down Expand Up @@ -332,7 +332,7 @@ jobs:
GITHUB_TOKEN: \${{ secrets.GITHUB_TOKEN }}
run: |
gh pr checkout \${{ github.event.pull_request.number }}
npm install --ignore-scripts
npm install --ignore-scripts --no-audit --no-fund
npm run template-oss-apply
git add .
git commit -am "chore: postinstall for dependabot template-oss PR"
Expand Down Expand Up @@ -632,7 +632,7 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts --package-lock
- run: npm i --ignore-scripts --no-audit --no-fund --package-lock
- run: npm audit

.github/workflows/ci-bbb.yml
Expand Down Expand Up @@ -673,7 +673,7 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm run lint -w bbb

test:
Expand Down Expand Up @@ -725,7 +725,7 @@ jobs:
if: \${{ !startsWith(matrix.node-version, '10.') }}
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm test --ignore-scripts -w bbb

.github/workflows/ci-name-aaaa.yml
Expand Down Expand Up @@ -766,7 +766,7 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm run lint -w @name/aaaa

test:
Expand Down Expand Up @@ -818,7 +818,7 @@ jobs:
if: \${{ !startsWith(matrix.node-version, '10.') }}
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm test --ignore-scripts -w @name/aaaa

.github/workflows/ci.yml
Expand Down Expand Up @@ -855,7 +855,7 @@ jobs:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm run lint

test:
Expand Down Expand Up @@ -907,7 +907,7 @@ jobs:
if: \${{ !startsWith(matrix.node-version, '10.') }}
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts
- run: npm i --ignore-scripts --no-audit --no-fund
- run: npm test --ignore-scripts

.github/workflows/codeql-analysis.yml
Expand Down Expand Up @@ -997,7 +997,7 @@ jobs:
GITHUB_TOKEN: \${{ secrets.GITHUB_TOKEN }}
run: |
gh pr checkout \${{ github.event.pull_request.number }}
npm install --ignore-scripts
npm install --ignore-scripts --no-audit --no-fund
npm run template-oss-apply
git add .
git commit -am "chore: postinstall for dependabot template-oss PR"
Expand Down
4 changes: 2 additions & 2 deletions tap-snapshots/test/check/diffs.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ The repo file ci.yml needs to be updated:
+ if: \${{ !startsWith(matrix.node-version, '10.') }}
+ run: npm i --prefer-online --no-fund --no-audit -g npm@latest
+ - run: npm -v
+ - run: npm i --ignore-scripts
+ - run: npm i --ignore-scripts --no-audit --no-fund
+ - run: npm test --ignore-scripts

To correct it: npx template-oss-apply --force
Expand Down Expand Up @@ -373,7 +373,7 @@ The repo file audit.yml needs to be updated:
- name: Update npm to latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- run: npm i --ignore-scripts --package-lock
- run: npm i --ignore-scripts --no-audit --no-fund --package-lock
- run: npm audit


Expand Down