Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not blow up if the opts object is mutated #4

Closed
wants to merge 5 commits into from
Closed

fix: Do not blow up if the opts object is mutated #4

wants to merge 5 commits into from

Commits on Oct 24, 2019

  1. fix: Do not blow up if the opts object is mutated 

    Pacote has a use case where the integrity value may not be known at the
outset, but is later established, either via the dist.integrity in a
packument, or by the x-local-hash header value when make-fetch-happen
loads a response from the cache.

In these cases, we have already started an integrity stream at the
beginning of the request, and don't get the expected integrity until
_after_ the integrity stream is created, resulting in a spurious
EINTEGRITY error.

This patch makes ssri responsive to (and resilient against) updates to
the integrity and size options after the stream has started.
    @isaacs
    isaacs committed Oct 24, 2019
    Copy the full SHA
    806e8c8 View commit details
    Browse the repository at this point in the history

  2. deps: minipass@3.1.1

    @isaacs
    isaacs committed Oct 24, 2019
    Copy the full SHA
    6545b4b View commit details
    Browse the repository at this point in the history

  3. deps: tap@14.8.2

    @isaacs
    isaacs committed Oct 24, 2019
    Copy the full SHA
    3084efd View commit details
    Browse the repository at this point in the history

  4. feat: Add Integrity#merge method 

    This is going to be used in Pacote to upgrade the Fetcher.integrity
value with the data that comes out of cacache, but in such a way that we
don't accidentally suppress integrity errors.
    @isaacs
    isaacs committed Oct 24, 2019
    Copy the full SHA
    065a924 View commit details
    Browse the repository at this point in the history

  5. chore: minor code cleanup nits 

    Via @mikemimik
    @isaacs
    isaacs committed Oct 24, 2019
    Copy the full SHA
    1065074 View commit details
    Browse the repository at this point in the history