Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement argument escaping when the shell option is set #44

Merged
merged 2 commits into from Nov 1, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Oct 27, 2022

No description provided.

@nlf nlf force-pushed the nlf/escaping branch 3 times, most recently from 5f3b467 to 836f2c4 Compare October 27, 2022 20:46
@nlf nlf changed the title feat: introduce shell mode with argument escaping chore: refactor tests to use spawk Oct 27, 2022
@nlf nlf marked this pull request as ready for review October 27, 2022 20:50
@nlf nlf requested a review from a team as a code owner October 27, 2022 20:50
@nlf nlf changed the title chore: refactor tests to use spawk feat: implement argument escaping when the shell option is set Oct 27, 2022
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved w/ a docs suggestion

BREAKING CHANGE: when the `shell` option is set provided arguments will automatically be escaped
@nlf nlf merged commit 723fc32 into main Nov 1, 2022
@nlf nlf deleted the nlf/escaping branch November 1, 2022 17:36
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants