fix(linting): no-unused-vars

lib/bin.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+/* eslint-disable no-console */
 
 const run = conf => {
   const pacote = require('../')

lib/git.js

@@ -156,7 +156,7 @@ class GitFetcher extends Fetcher {
   [_resolvedFromClone] () {
     // do a full or shallow clone, then look at the HEAD
     // kind of wasteful, but no other option, really
-    return this[_clone](dir => this.resolved)
+    return this[_clone](() => this.resolved)
   }
 
   [_prepareDir] (dir) {

test/bin.js

@@ -23,7 +23,7 @@ pacote.manifest = (spec, conf) => Promise.resolve({
 pacote.packument = (spec, conf) => Promise.resolve({ method: 'packument', spec, conf })
 pacote.tarball.file = (spec, file, conf) => Promise.resolve({ method: 'tarball', spec, file, conf })
 const { Minipass } = require('minipass')
-pacote.tarball.stream = (spec, handler, conf) => handler(new Minipass().end('tarball data'))
+pacote.tarball.stream = (spec, handler) => handler(new Minipass().end('tarball data'))
 pacote.extract = (spec, dest, conf) => Promise.resolve({ method: 'extract', spec, dest, conf })
 
 t.test('running bin runs main file', t => {

test/fetcher.js

@@ -94,11 +94,11 @@ t.test('tarball data', async t => {
 
 t.test('tarballFile', t => {
   const target = resolve(me, 'tarball-file')
-  t.test('basic copy', t =>
+  t.test('basic copy', () =>
     new FileFetcher(abbrevspec, { cache })
       .tarballFile(target + '/basic/1.tgz'))
 
-  t.test('again, folder already created', t =>
+  t.test('again, folder already created', () =>
     new FileFetcher(abbrevspec, { cache })
       .tarballFile(target + '/basic/2.tgz'))
 

test/git.js

@@ -87,7 +87,7 @@ const tar = require('tar')
 
 let REPO_HEAD = ''
 t.test('setup', { bail: true }, t => {
-  t.test('create repo', t => {
+  t.test('create repo', () => {
     const git = (...cmd) => spawnGit(cmd, { cwd: repo })
     const write = (f, c) => fs.writeFileSync(`${repo}/${f}`, c)
     const npm = (...cmd) => spawnNpm('npm', [
@@ -162,7 +162,7 @@ t.test('setup', { bail: true }, t => {
       .then(({ stdout }) => REPO_HEAD = stdout.trim())
   })
 
-  t.test('create cycle of git prepared deps', async t => {
+  t.test('create cycle of git prepared deps', async () => {
     for (const repoDir of [cycleA, cycleB]) {
       const git = (...cmd) => spawnGit(cmd, { cwd: repoDir })
       const write = (f, c) => fs.writeFileSync(`${repoDir}/${f}`, c)
@@ -227,7 +227,7 @@ t.test('setup', { bail: true }, t => {
     daemon.on('close', () => rmSync(me, { recursive: true, force: true }))
   })
 
-  t.test('create a repo with a submodule', t => {
+  t.test('create a repo with a submodule', () => {
     const submoduleRepo = resolve(me, 'submodule-repo')
     const git = (...cmd) => spawnGit(cmd, { cwd: submoduleRepo })
     const write = (f, c) => fs.writeFileSync(`${submoduleRepo}/${f}`, c)
@@ -285,7 +285,7 @@ t.test('setup', { bail: true }, t => {
       .then(() => git('commit', '-m', 'package'))
   })
 
-  t.test('create a repo with workspaces', t => {
+  t.test('create a repo with workspaces', () => {
     const workspacesRepo = resolve(me, 'workspaces-repo')
     const wsfolder = resolve(me, 'workspaces-repo/a')
     const git = (...cmd) => spawnGit(cmd, { cwd: workspacesRepo })
@@ -315,7 +315,7 @@ t.test('setup', { bail: true }, t => {
       .then(() => git('commit', '-m', 'a/package.json'))
   })
 
-  t.test('create a repo with only a prepack script', t => {
+  t.test('create a repo with only a prepack script', () => {
     const prepackRepo = resolve(me, 'prepack-repo')
     const git = (...cmd) => spawnGit(cmd, { cwd: prepackRepo })
     const write = (f, c) => fs.writeFileSync(`${prepackRepo}/${f}`, c)
@@ -608,7 +608,7 @@ t.test('fetch a weird ref', t => {
   t.end()
 })
 
-t.test('fetch a private repo where the tgz is a 404', t => {
+t.test('fetch a private repo where the tgz is a 404', () => {
   const gf = new GitFetcher(`localhost:repo/x#${REPO_HEAD}`, opts)
   gf.spec.hosted.tarball = () => `${hostedUrl}/not-found.tgz`
   // should fetch it by falling back to ssh when it gets an http error