Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Match node's resolution when validating peer dependencies #19905

Closed

Conversation

bjornstar
Copy link

Fixes #15708

I've created an organization to reproduce the problem: peer-deps-repro

To reproduce:

git clone git@github.com:peer-deps-repro/main.git
git checkout v1.2.0
npm install

There should be no warnings when you install.

The problem is that the validator was not using the same module resolution strategy as node and matching the wrong version. We need to go up the tree and use the nearest peer dependency.

@bjornstar bjornstar requested a review from a team as a code owner February 24, 2018 03:24
@bjornstar
Copy link
Author

It turns out that this is not the same resolution strategy and the deduping method used since v3.0.0 is flawed. Child dependencies are getting the wrong version.

@bjornstar bjornstar closed this Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant