This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Match node's resolution when validating peer dependencies #19905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15708
I've created an organization to reproduce the problem:
peer-deps-repro
To reproduce:
There should be no warnings when you install.
The problem is that the validator was not using the same module resolution strategy as node and matching the wrong version. We need to go up the tree and use the nearest peer dependency.