Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ErrorBase always capture stack trace #239

Merged
merged 4 commits into from May 2, 2024
Merged

Conversation

lukekarrys
Copy link
Contributor

fix: allow HttpErrorBase to take headers object

fix: allow HttpErrorBase to take headers object
@lukekarrys lukekarrys requested a review from a team as a code owner May 1, 2024 19:53
lib/errors.js Outdated Show resolved Hide resolved
lib/errors.js Outdated Show resolved Hide resolved
@wraithgar
Copy link
Member

headers.raw change will need a test and I'd love to know what cause that to be needed.

@lukekarrys
Copy link
Contributor Author

Added a test for headers.raw. These errors are used in npm-profile and there's one spot there a headers object was given a raw function just to return the object like headers: { raw: () => er.headers }

Co-authored-by: Gar <gar+gh@danger.computer>
lib/errors.js Outdated Show resolved Hide resolved
lib/errors.js Outdated Show resolved Hide resolved
@lukekarrys lukekarrys merged commit 45cef0a into main May 2, 2024
20 checks passed
@lukekarrys lukekarrys deleted the lk/errors branch May 2, 2024 15:48
@github-actions github-actions bot mentioned this pull request May 2, 2024
lukekarrys pushed a commit that referenced this pull request May 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[17.0.1](v17.0.0...v17.0.1)
(2024-05-02)

### Bug Fixes

*
[`45cef0a`](45cef0a)
[#239](#239) allow
HttpErrorBase to take headers object (@lukekarrys, @wraithgar)
*
[`45cef0a`](45cef0a)
[#239](#239) make
ErrorBase always capture stack trace (#239) (@lukekarrys, @wraithgar)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants