update tap to latest to run test locally #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2021 15:03
Signed-off-by: 司芳源 <sify1221@gmail.com>
Signed-off-by: 司芳源 <sify1221@gmail.com>
ljharb
reviewed
Sep 18, 2021
package.json
Outdated
| @@ -11,7 +11,7 @@ | |||
| "postpublish": "git push origin --follow-tags" | |||
| }, | |||
| "devDependencies": { | |||
| "tap": "^14.10.7" | |||
| "tap": ">14.10.7" | |||
There was a problem hiding this comment.
You never want to use > - the ^ already means “use the latest of v14.x”
There was a problem hiding this comment.
the issue is not fixed until 15.0.4. I changed it to ^15.0.4
Signed-off-by: 司芳源 <sify1221@gmail.com>
|
Closing in favor of #433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 司芳源 sify1221@gmail.com
I can not run tests locally using node version
v16.8.0.t.done()tot.end()intest/functions/coerce.jsThere are still 3 failed tests, I'm not familiar with Promise and don't know how to fix them.
References
Related to tapjs/tapjs#746