Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless regular-expression character escape #359

Closed

Conversation

smorimoto
Copy link

This PR fixes the problem found by #358 (though it's hardly a problem).

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8a1e162 on smorimoto:remove-useless-regex-char-escape into 093b40f on npm:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8a1e162 on smorimoto:remove-useless-regex-char-escape into 093b40f on npm:master.

@lukekarrys
Copy link
Member

The escape is useless, but the fix should be to add another \ so the resulting regex only matches a literal . and not any character. I implemented this in #432.

@lukekarrys lukekarrys closed this Feb 26, 2022
@smorimoto smorimoto deleted the remove-useless-regex-char-escape branch February 26, 2022 14:01
@smorimoto
Copy link
Author

@lukekarrys Brilliant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants