docs: Package-json.md - Updated example for monorepo and json to jsonc #6656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json to jsonc. for sections with comments. Minor change for github markdown to stop showing
Updated example for monorepo, react, react-dom Also, added tree folder structure
wraithgar
reviewed
Jul 21, 2023
| ```json | ||
| If your `package.json` isn't in the root directory, common with monorepos like Facebook's React, you can specify its location. i.e. `react-dom`: | ||
| ```jsonc | ||
| /* @/packages/react-dom/package.json */ |
There was a problem hiding this comment.
I'm not sure this is a helpful comment, is it just a bare comment of a path with some sort of "shorthand" for @ meaning cwd?
There was a problem hiding this comment.
I'm not sure this is a helpful comment, is it just a bare comment of a path with some sort of "shorthand" for
@meaningcwd?
Yea. I couldn't think of a good shorthand. This felt too long:
https://github.com/facebook/react/blob/main/packages/react-dom/package.json
I wanted to be verbose on which package.json the block was referring to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added folder tree to visualize example.
References