version: using 'allow-same-version', git commit --allow-empty and git tag -f #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @rhengles, this does looks good! can you please add some tests? 😊 |
ruyadorno
added
pr: needs tests
|
@ruyadorno Thank you! I'll arrange that. |
|
@ruyadorno Done! Let me know if this is good. |
ruyadorno
approved these changes
Jan 9, 2020
ruyadorno
pushed a commit
that referenced
this pull request
Jan 9, 2020
…nd git tag -f PR-URL: #648 Credit: @rhengles Close: #648 Reviewed-by: @ruyadorno
This was referenced Jan 10, 2020
Merged
This was referenced Jan 18, 2020
Closed
This was referenced Feb 10, 2020
This was referenced Feb 25, 2020
This was referenced Mar 9, 2020
This was referenced Mar 17, 2020
This was referenced Mar 19, 2020
This was referenced Mar 26, 2020
This was referenced Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
When running
npm version "x.x.x" --allow-same-version, it often is the case thatgit commitwill fail because there are no changes to commit, and thatgit tag vx.x.xwill fail because the tag already exists.The changes here are exactly these to prevent failure only when the option
allow-same-versionis activated.