Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): remove node_modules post-validation #4913

Merged
merged 1 commit into from May 18, 2022
Merged

fix(ci): remove node_modules post-validation #4913

merged 1 commit into from May 18, 2022

Commits on May 18, 2022

  1. fix(ci): remove node_modules post-validation 

    The removal of node_modules was happening in a race with the loading of
the virtualTree, and before the validation of the package-lock against
the package.json.  This defers the removal till after all that
validation has happened.

It also makes the errors thrown usage errors, and refactors the tests to
be real.
    @wraithgar
    wraithgar committed May 18, 2022
    Copy the full SHA
    a2f4119 View commit details
    Browse the repository at this point in the history