Fix package id in shrinkwrap lifecycle step output #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bz2
force-pushed
the
lifecycle_shrinkwrap_id
branch
from
e613715
to
3c7d80e
Compare
Currently all logging related to shrinkwrap steps reports 'undefined' for the package in output and log messages. This is due to the package associated with the `idealTree` being recreated in the `savePackageJson()` method which precedes these steps. For now, just copy forward the `_id` attribute which lifecycle logging expects, but note that mutating `package` here is surprising. Fixes npm/npm#20756
bz2
force-pushed
the
lifecycle_shrinkwrap_id
branch
from
3c7d80e
to
38d91de
Compare
Not supported on node 6 apparently. Can get the same effect by explictly matching the newline character.
|
@ruyadorno @claudiahdz Is there anything I can do to help get this reviewed and landed? What kind of discussion is needed exactly? This is a pretty simple change that improves error output for steps after post install. |
|
This looks good to me. It's irrelevant in npm v7, but we may as well fix this little thing in the meantime. Sorry for the delay, we're all pretty focused on getting the next major done. Thanks for your patience. |
isaacs
approved these changes
May 26, 2020
|
@claudiahdz It it possible for you to merge this? I do not have write access to actually land. @isaacs Thank you for the review. I like the streamlined upcoming changes, though it now doesn't say which script has failed: |
ruyadorno
added
Release 6.x
|
This will be added on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all logging related to shrinkwrap steps reports 'undefined'
for the package in output and log messages.
This is due to the package associated with the
idealTreebeingrecreated in the
savePackageJson()method which precedes thesesteps. For now, just copy forward the
_idattribute which lifecyclelogging expects, but note that mutating
packagehere is surprising.Fixes npm/npm#20756