Combined BMP RLE decoders #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yay295
reviewed
Oct 23, 2022
Comment on lines
+329
to
+339
| if rle4: | ||
| # 2 pixels per byte | ||
| byte_count = byte[0] // 2 | ||
| bytes_read = self.fd.read(byte_count) | ||
| for byte_read in bytes_read: | ||
| data += o8(byte_read >> 4) | ||
| data += o8(byte_read & 0x0F) | ||
| else: | ||
| byte_count = byte[0] | ||
| bytes_read = self.fd.read(byte_count) | ||
| data += bytes_read |
There was a problem hiding this comment.
The first two lines of code in each branch here are the same (other than the comment), so they could be pulled out of the if..else.
There was a problem hiding this comment.
The first line of the first branch is byte_count = byte[0] // 2 and the first line of the second branch is byte_count = byte[0]. As I noted elsewhere, // 2 isn't a comment, it's division.
|
I've merged this in. Normally I'd wait longer to see if you had any thoughts on my suggestions, but Pillow 9.3.0 is fast approaching, and I expect you're more interested in this functionality making it into that release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two suggestions for python-pillow#6674
prints 2.