Ensure the BonjourBrowser sets ServiceName - iOS, Bug #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am no mDNS buff, but I believe the Service name is derived from the NSNetService.HostName in this case.
Give a friendly exception about how the ServiceName was not set. It might be worth enabling Nullable on the project to prevent this. Or at least add a constructor to `Service`
twofingerrightclick
changed the title
|
Hi. Are you going to merge this PR and make a new nuget version? It's very important for my app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ServiceName was not being set on the ZeroconfRecord Service as part of the BonjourBrowser pipeline. This resulted in an obscure null key exception. See issue #244 for details.