Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hardcoded reserve price from the webapp #832

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

0xMillz
Copy link

@0xMillz 0xMillz commented Jan 30, 2024

No description provided.

@bagelface
Copy link

I think this is a great change that adds needed transparency on the frontend. I think this in combination with the non-optional setting would be an ideal solution. I'll make a PR from my branch into yours in case that's the route we all settle on.

@0xMillz
Copy link
Author

0xMillz commented Jan 30, 2024

I think this is a great change that adds needed transparency on the frontend. I think this in combination with the non-optional setting would be an ideal solution. I'll make a PR from my branch into yours in case that's the route we all settle on.

Glad you agree! I left it as a draft for right now because I haven't fully finished regression testing against my local and Sepolia networks. I'll probably have one more small change before marking it ready for review.

While I do have slight differences of opinion in the two PRs that focus on the contracts package, I felt they are better suited as review comments rather than bundling them into this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants