Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NounsAuctionHouseV2 - BidWithComment Upgrade #755

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

NounsAuctionHouseV2 - BidWithComment Upgrade #755

wants to merge 41 commits into from

Conversation

EricDevito
Copy link
Contributor

@EricDevito EricDevito commented Jul 12, 2023 •
edited

tl;dr - Vote With Reason for auction bids.

This upgrade gives bidders the option to leave a comment alongside their bid - preferably reasons for why they'd like to become lil nouner, what they'd add to the community, or why and how a particular lil noun caught their eye.

PR includes:

  • AuctionHouse.sol and IAuctionHouse.sol upgrades
  • UI changes to surface bid comments for past /current auctions and allow bidders to provide an optional comment with their bids, with gas calculated per byte.
  • @nouns-subgraph update to surface comments from bid events
  • @nouns-bots upgrade to surface comments on bid event

@EricDevito
contract upgrade
abb9990
@EricDevito
add bidWithComment to subgraph
b5e11b0
@EricDevito
add bidWithComment to bot
4b21746
@EricDevito
add bidWithComment to wrappers and redux
df9c277
@EricDevito
update subgraph and contracts
efc881b
@EricDevito
update subgraph wrapper
1d4cd63
@EricDevito
bidWithComment UI
ec708a7
@EricDevito
Merge branch 'bidwithcomment' of https://github.com/EricDevito/nouns-…
de320e9 
…monorepo into bidwithcomment
@EricDevito
UI cleanup
9971c42
@EricDevito
yarn install and update WalletConnectV2 util
0586d67
@EricDevito
wrap CommentModal title in lingui macro
e353d36
@EricDevito
BidHistoryModalRow hover
5dfbcbe
@EricDevito
remove console log
aec4e82
@EricDevito
optimizations for mobile
c4709a4
@EricDevito
update subgraph to fetch old AH contract events
ad66b6e
@EricDevito
handle bid comment in separate event
833ae2a
@EricDevito
update subgraph
5e0f875
@EricDevito
remove old ah contract
ee7de17
@EricDevito
update webapp
b349baf
@EricDevito
nounsAuctionHouseV2
fdd65df
@EricDevito
point to NounsAuctionHouseV2 interface
09eef83
@EricDevito
propose AuctionHouse.sol upgrade via prop
1c5956f
@EricDevito
bid with comment tests in auction and end2end hardhat tests
743c36b
@EricDevito
Tests: upgrade auctionHouseV2 via prop
37b113e
@EricDevito
Scripts: upgrade auctionHouseV2 via prop
0e1e806
@EricDevito
add auctionHouse deployement functions
54e1f79
@EricDevito
auctionHouseV2.sol forge tests
62facbf
@EricDevito
auctionHouseV2 forge test
e22e032
@EricDevito EricDevito changed the title BidWithComment upgrades from Lil Nouns DAO NounsAuctionHouseV2 - BidWithComment Upgrade Dec 25, 2023
@EricDevito
Copy link
Contributor Author

Upgrade to mainnet subgraph required before merge.
Also, testing here (sepolia): https://master--stellular-cat-047478.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EricDevito @solimander