Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV 1.72 #569

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

MSRV 1.72 #569

wants to merge 7 commits into from

Conversation

dfaust
Copy link
Collaborator

@dfaust dfaust commented Feb 21, 2024

  • Raise MSRV to 1.72
  • Remove internal use of crossbeam because std::sync::mpsc::Sender implements Sync since version 1.72, so there is no need for crossbeam anymore
  • Specify dependencies in workspace

I screwed up a bit and this PR is based on my previous on (#567).

@0xpr03
Copy link
Member

0xpr03 commented Mar 28, 2024

Let's merge this with #568 as 7.0 and try to get everything else into 6.X

Or is there anything else that would be major breaking ?

@0xpr03 0xpr03 added this to the notify-7.0 milestone Mar 28, 2024
@dfaust
Copy link
Collaborator Author

dfaust commented Mar 28, 2024

The change to the event serialization is already in main. And that's breaking.
I don't think releasing another 6.x version is worth the effort.

@0xpr03
Copy link
Member

0xpr03 commented Mar 28, 2024

Ah yeah, my bad. Nevermind then, break all the things.

@0xpr03
Copy link
Member

0xpr03 commented Mar 28, 2024

This also needs a rebase

@0xpr03
Copy link
Member

0xpr03 commented Mar 31, 2024

I'll re-rebase this when I'm back at home (+2days!). Then I wall have to look at the outstanding issues and PR that accumulated over the past ~2 months and push the release finally over the line..

Thanks for all the work!

@dfaust
Copy link
Collaborator Author

dfaust commented May 6, 2024

Can we merge this? I already based my next PR on this one.

@dfaust dfaust mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants