Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsevent: use RenameMode::Any for renaming events #371

Merged
merged 1 commit into from Jan 9, 2022
Merged

fsevent: use RenameMode::Any for renaming events #371

merged 1 commit into from Jan 9, 2022

Conversation

andelf
Copy link
Contributor

@andelf andelf commented Dec 2, 2021

FSEvents provides no mechanism to associate the old and new sides of a rename event. It only produces an event at the old and new paths with kFSEventStreamEventFlagItemRenamed bit set.

Ref: https://github.com/atom/watcher/blob/master/docs/macos.md

@0xpr03
Copy link
Member

0xpr03 commented Dec 2, 2021

Thanks for the PR. Can we somehow test this ? I don't use macos/bsd at all, so having some kind of sanity test for this would be very appreciated.

@dhiemaz
Copy link

dhiemaz commented Dec 2, 2021

I use mac here.. @0xpr03

@0xpr03
Copy link
Member

0xpr03 commented Jan 4, 2022

@dhiemaz did you verify this ?

@dhiemaz
Copy link

dhiemaz commented Jan 5, 2022

Let me check it first @0xpr03

@dhiemaz
Copy link

dhiemaz commented Jan 9, 2022

Okay from me..

0xpr03
0xpr03 approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@0xpr03 0xpr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xpr03 0xpr03 merged commit 8948dd1 into notify-rs:main Jan 9, 2022
ecioppettini added a commit to input-output-hk/vit-servicing-station that referenced this pull request Mar 23, 2022
@ecioppettini
trigger update on all rename events
ad3a5b4 
partly because of notify-rs/notify#371 but also
because if the file gets renamed then it's just as if it was deleted and
we already handling the remove
ecioppettini added a commit to input-output-hk/vit-servicing-station that referenced this pull request May 3, 2022
@ecioppettini
trigger update on all rename events
4f52abc 
partly because of notify-rs/notify#371 but also
because if the file gets renamed then it's just as if it was deleted and
we already handling the remove
@andelf andelf deleted the fix/fsevent-rename branch May 12, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xpr03 0xpr03 0xpr03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andelf @0xpr03 @dhiemaz