Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cursors): Use data-uris for cursors #266

Merged
merged 5 commits into from Feb 7, 2019
Merged

refactor(cursors): Use data-uris for cursors #266

merged 5 commits into from Feb 7, 2019

Conversation

trezy
Copy link
Member

@trezy trezy commented Jan 30, 2019 •
edited by BcRikko

I've switched us from using file-loader to url-loader. This will automatically convert local URL
imports to data URIs, which means the framework no longer needs to load them from a remote URL.

fix #207

@trezy
refactor(cursors): Use data-uris for cursors
1b0db4a 
I've switched us from using `file-loader` to `url-loader`. This will automatically convert local URL
imports to data URIs, which means the framework no longer needs to load them from a remote URL.

#207
@trezy trezy added the enhancement New feature or request label Jan 30, 2019
@trezy trezy self-assigned this Jan 30, 2019
@trezy trezy requested a review from a team January 30, 2019 19:34
guastallaigor
guastallaigor previously approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@guastallaigor guastallaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BcRikko
Copy link
Member

BcRikko commented Jan 31, 2019

It's cool 🎉

If you don't use file-loader, could you uninstall it?

$ npm uninstall -D file-loader

@guastallaigor guastallaigor added the waiting - contributor Waiting for the contributor to address some situations label Feb 4, 2019
@BcRikko BcRikko self-assigned this Feb 6, 2019
@BcRikko
Copy link
Member

BcRikko commented Feb 7, 2019 •
edited

I found the cause of build error 🔍👀

But I can't push it to GitHub now 😭
I'll push it when I get home. 🏠

# update package-lock.json
$ npm update globby --depth 5

postcss/postcss-cli#265 (comment)

guastallaigor
guastallaigor approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@guastallaigor guastallaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉
LGTM

@guastallaigor guastallaigor merged commit 1930546 into develop Feb 7, 2019
@BcRikko BcRikko deleted the feat/use-data-uris-for-cursors branch February 7, 2019 14:08
@BcRikko
Copy link
Member

BcRikko commented Feb 16, 2019

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@guastallaigor guastallaigor removed the waiting - contributor Waiting for the contributor to address some situations label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guastallaigor guastallaigor guastallaigor approved these changes

Assignees

@trezy trezy

@BcRikko BcRikko

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use data URIs for cursors?
3 participants
@trezy @BcRikko @guastallaigor