Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.guava:guava from 30.1-jre to 32.0.0-jre in /nb-adapters/adapter-qdrant #1943

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 10, 2024

Bumps com.google.guava:guava from 30.1-jre to 32.0.0-jre.

Release notes

Sourced from com.google.guava:guava's releases.

32.0.0

Maven

<dependency>
  <groupId>com.google.guava</groupId>
  <artifactId>guava</artifactId>
  <version>32.0.0-jre</version>
  <!-- or, for Android: -->
  <version>32.0.0-android</version>
</dependency>

Jar files

Guava requires one runtime dependency, which you can download here:

Javadoc

JDiff

Changelog

Security fixes

While CVE-2020-8908 was officially closed when we deprecated Files.createTempDir in Guava 30.0, we've heard from users that even recent versions of Guava have been listed as vulnerable in other databases of security vulnerabilities. In response, we've reimplemented the method (and the very rarely used FileBackedOutputStream class, which had a similar issue) to eliminate the insecure behavior entirely. This change could technically affect users in a number of different ways (discussed under "Incompatible changes" below), but in practice, the only problem users are likely to encounter is with Windows. If you are using those APIs under Windows, you should skip 32.0.0 and go straight to 32.0.1 which fixes the problem. (Unfortunately, we didn't think of the Windows problem until after the release. And while we warn that common.io in particular may not work under Windows, we didn't intend to regress support.) Sorry for the trouble.

Incompatible changes

Although this release bumps Guava's major version number, it makes no binary-incompatible changes to the guava artifact.

One change could cause issues for Widows users, and a few other changes could cause issues for users in more usual situations:

  • The new implementations of Files.createTempDir and FileBackedOutputStream throw an exception under Windows. This is fixed in 32.0.1. Sorry for the trouble.
  • guava-gwt now requires GWT 2.10.0.
  • This release makes a binary-incompatible change to a @Beta API in the separate artifact guava-testlib. Specifically, we changed the return type of TestingExecutors.sameThreadScheduledExecutor to ListeningScheduledExecutorService. The old return type was a package-private class, which caused the Kotlin compiler to produce warnings. (dafaa3e435)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [com.google.guava:guava](https://github.com/google/guava) from 30.1-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels May 10, 2024
@msmygit
Copy link
Contributor

msmygit commented May 13, 2024

I'm checking to see if the later versions is working okay with this Qdrant driver. Will act on this PR once completing my testing. Stay tuned.

@msmygit
Copy link
Contributor

msmygit commented May 14, 2024

When I try to update it to the current latest of 33.1.0-jre, I get,

    3651 INFO  [schema_collection:001] QdrantSpace  default: Creating new Qdrant Client with (masked) token [_Dn**hird*K*S*hq*UsoRHpWzp*gB-yYVRDOwinuA*TlTlNzGuFNKQ], uri/endpoint [ded78a51-8370-47d8-adb0-6147f0fcbba2.us-east4-0.gcp.cloud.qdrant.io]
May 13, 2024 10:59:47 PM io.grpc.internal.ManagedChannelImpl$2 uncaughtException
SEVERE: [Channel<1>: (ded78a51-8370-47d8-adb0-6147f0fcbba2.us-east4-0.gcp.cloud.qdrant.io:6334)] Uncaught exception in the SynchronizationContext. Panic!
java.lang.NoSuchMethodError: 'boolean io.grpc.LoadBalancer.acceptResolvedAddresses(io.grpc.LoadBalancer$ResolvedAddresses)'
	at io.grpc.internal.AutoConfiguredLoadBalancerFactory$AutoConfiguredLoadBalancer.tryAcceptResolvedAddresses(AutoConfiguredLoadBalancerFactory.java:142)
	at io.grpc.internal.ManagedChannelImpl$NameResolverListener$1NamesResolved.run(ManagedChannelImpl.java:1854)
	at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:94)
	at io.grpc.SynchronizationContext.execute(SynchronizationContext.java:126)
	at io.grpc.internal.ManagedChannelImpl$NameResolverListener.onResult(ManagedChannelImpl.java:1868)
	at io.grpc.internal.RetryingNameResolver$RetryingListener.onResult(RetryingNameResolver.java:98)
	at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:333)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

    3877 ERROR [grpc-default-executor-0] QdrantClient Create collection operation failed
io.grpc.StatusRuntimeException: INTERNAL: Panic! This is a bug!
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:538)
	at io.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:489)
	at io.grpc.internal.DelayedClientCall$DelayedListener.drainPendingCallbacks(DelayedClientCall.java:528)
	at io.grpc.internal.DelayedClientCall$1DrainListenerRunnable.runInContext(DelayedClientCall.java:317)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.NoSuchMethodError: 'boolean io.grpc.LoadBalancer.acceptResolvedAddresses(io.grpc.LoadBalancer$ResolvedAddresses)'
	at io.grpc.internal.AutoConfiguredLoadBalancerFactory$AutoConfiguredLoadBalancer.tryAcceptResolvedAddresses(AutoConfiguredLoadBalancerFactory.java:142)
	at io.grpc.internal.ManagedChannelImpl$NameResolverListener$1NamesResolved.run(ManagedChannelImpl.java:1854)
	at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:94)
	at io.grpc.SynchronizationContext.execute(SynchronizationContext.java:126)
	at io.grpc.internal.ManagedChannelImpl$NameResolverListener.onResult(ManagedChannelImpl.java:1868)
	at io.grpc.internal.RetryingNameResolver$RetryingListener.onResult(RetryingNameResolver.java:98)
	at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:333)
	... 3 more
    3891 INFO  [] ANNOTATION   {"layer":"Activity","start":1715655586701,"end":1715655587428,"details":{"event":"stop-activity","params":"ActivityDef:(20)/{workload\u003dqdrant_vectors_live, cycles\u003d1, stride\u003d1, uri\u003dded78a51-8370-47d8-adb0-6147f0fcbba2.us-east4-0.gcp.cloud.qdrant.io, tags\u003dblock:schema_collection, labels\u003dworkload:qdrant_vectors_live,scenario:qdrant_vectors.schema_collection, alias\u003dschema_collection, errors\u003dstop}"}}
    3891 ERROR [schema_collection:001] CoreMotor    Error in core motor loop:java.lang.RuntimeException: java.lang.RuntimeException: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: INTERNAL: Panic! This is a bug!
java.lang.RuntimeException: java.lang.RuntimeException: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: INTERNAL: Panic! This is a bug!
	at io.nosqlbench.engine.api.activityapi.errorhandling.modular.handlers.StopErrorHandler.handleError(StopErrorHandler.java:32)
	at io.nosqlbench.engine.api.activityapi.errorhandling.modular.NBErrorHandler.handleError(NBErrorHandler.java:68)
	at io.nosqlbench.engine.api.activityimpl.uniform.actions.StandardAction.runCycle(StandardAction.java:133)
	at io.nosqlbench.engine.api.activityimpl.motor.CoreMotor.run(CoreMotor.java:271)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.RuntimeException: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: INTERNAL: Panic! This is a bug!
	at io.nosqlbench.adapter.qdrant.ops.QdrantCreateCollectionOp.applyOp(QdrantCreateCollectionOp.java:43)
	at io.nosqlbench.adapter.qdrant.ops.QdrantBaseOp.apply(QdrantBaseOp.java:51)
	at io.nosqlbench.engine.api.activityimpl.uniform.actions.StandardAction.runCycle(StandardAction.java:102)
	... 4 more
Caused by: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: INTERNAL: Panic! This is a bug!
	at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:594)
	at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:573)
	at com.google.common.util.concurrent.FluentFuture$TrustedFuture.get(FluentFuture.java:91)
	at io.nosqlbench.adapter.qdrant.ops.QdrantCreateCollectionOp.applyOp(QdrantCreateCollectionOp.java:41)
	... 6 more
Caused by: io.grpc.StatusRuntimeException: INTERNAL: Panic! This is a bug!
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:538)
	at io.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:489)
	at io.grpc.internal.DelayedClientCall$DelayedListener.drainPendingCallbacks(DelayedClientCall.java:528)
	at io.grpc.internal.DelayedClientCall$1DrainListenerRunnable.runInContext(DelayedClientCall.java:317)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	... 3 more
Caused by: java.lang.NoSuchMethodError: 'boolean io.grpc.LoadBalancer.acceptResolvedAddresses(io.grpc.LoadBalancer$ResolvedAddresses)'
	at io.grpc.internal.AutoConfiguredLoadBalancerFactory$AutoConfiguredLoadBalancer.tryAcceptResolvedAddresses(AutoConfiguredLoadBalancerFactory.java:142)
	at io.grpc.internal.ManagedChannelImpl$NameResolverListener$1NamesResolved.run(ManagedChannelImpl.java:1854)
	at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:94)
	at io.grpc.SynchronizationContext.execute(SynchronizationContext.java:126)
	at io.grpc.internal.ManagedChannelImpl$NameResolverListener.onResult(ManagedChannelImpl.java:1868)
	at io.grpc.internal.RetryingNameResolver$RetryingListener.onResult(RetryingNameResolver.java:98)
	at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:333)
	... 3 more
    3892 ERROR [schema_collection:001] ActivityExceptionHandler Uncaught exception in thread 'schema_collection:001, state[RUNNABLE], notifying executor 'ActivityExecutor~schema_collection': java.lang.RuntimeException: java.lang.RuntimeException: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: INTERNAL: Panic! This is a bug!
    4152 INFO  [schema_collection:001] ActivityExecutor stopping activity schema_collection:Errored:⌀(0) ⏫(0) ⏵(0) ⏬(0) ⏹(0) ⏯(0) ⚠(1)
    4153 WARN  [schema_collection:001] CoreMotor    attempted to stop motor 0: from non Running state:Errored
    4161 INFO  [main] NBINVOKE     result   [CMD_run {container="qdrant_vectors.schema_collection",dataset="glove-25",dimensions="25",instance="vectors",jobname="nosqlbench",node="192.168.1.117",session="nYQ2FwG",step="run",target="qdrant",vendor="qdrant_v191"}]: NULL
    4162 INFO  [main] NBBufferedContainer VARS:{}
    4162 INFO  [main] PROGRESS     schema_collection (pending,current,complete)=(0,0,1) 100.00% (last report)
    4172 ERROR [main] ERRORHANDLER internal error: Error while waiting for activity completion with states [⌀(0) ⏫(0) ⏵(0) ⏬(0) ⏹(0) ⏯(0) ⚠(1)], error=[no error on activity executor]
java.lang.RuntimeException: Error while waiting for activity completion with states [⌀(0) ⏫(0) ⏵(0) ⏬(0) ⏹(0) ⏯(0) ⚠(1)], error=[no error on activity executor]
	at io.nosqlbench.engine.core.lifecycle.activity.ActivityExecutor.awaitActivityCompletion(ActivityExecutor.java:517)
	at io.nosqlbench.engine.core.lifecycle.activity.ActivityExecutor.call(ActivityExecutor.java:418)
	at io.nosqlbench.engine.core.lifecycle.activity.ActivityExecutor.call(ActivityExecutor.java:62)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.lang.VirtualThread.run(VirtualThread.java:311)
Scenario stopped due to error. See logs for details.

Process finished with exit code 2

exception!

@msmygit
Copy link
Contributor

msmygit commented May 14, 2024

The above exception is unrelated as it was actually caused by grpc-protobuf version upgrade. This will be taken care at #1947 PR

@msmygit
Copy link
Contributor

msmygit commented May 14, 2024

Closing this PR as we now have a more recent version added as part of another PR.

@msmygit msmygit closed this May 14, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 14, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@msmygit msmygit deleted the dependabot/maven/nb-adapters/adapter-qdrant/com.google.guava-guava-32.0.0-jre branch May 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Development

Successfully merging this pull request may close these issues.

None yet

2 participants