Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario parser should honor double and single quotes in values #1941

Merged
merged 4 commits into from May 10, 2024

Conversation

sahankj2000
Copy link
Contributor

Description

Scenario parser does not honor double quotes and single quotes inside scenario definitions.

Issue: #1888

Previous and new behaviours in parsing

previous:   param="test1" -> param="test1"
new:        param="test1" -> param=test1

previous:   param="test 1" -> 5811 ERROR [main] ERRORHANDLER Unable to recognize scenario cmd spec in '1"'
new:        param="test 1" -> param=test 1

previous:   param=\"test1\" -> param=\"test1\"
new:        param=\"test1\" -> param="test1"

previous:   param="\"test 1\"" -> 5751 ERROR [main] ERRORHANDLER Unable to recognize scenario cmd spec in '1\""'
new:        param="\"test 1\"" -> param="test 1"
  • New behaviours are made similar to the behaviour when running directly from commandline

@jshook jshook linked an issue May 10, 2024 that may be closed by this pull request
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshook jshook merged commit f3ab1fa into nosqlbench:main May 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Scenario parser should honor double and single quotes in values
2 participants