Added to check if the driver is invalid #1933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @workdone0 for the contribution. Will you also be able to merge in this unit test on this pr? |
Unit test for using non-existent driver
jshook
reviewed
May 1, 2024
| @@ -218,6 +220,19 @@ public Integer applyDirect(final String[] args) { | |||
| } | |||
|
|
|||
| final NBCLIOptions options = new NBCLIOptions(args, Mode.ParseAllOptions); | |||
|
|
|||
There was a problem hiding this comment.
Can we move this to an adjacent class, or put it into an Optional friendly call on DriverAdapterLoader or similar? We need to keep NBCLI high-level as much as possible.
There was a problem hiding this comment.
@jshook I moved the logic to an adjacent class but it seems like some test are failing. I reviewed the code it looks fine, do you have any suggestion or should I revert the changes.
jshook
requested changes
May 1, 2024
|
closes #1006 |
jshook
requested changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warn the user if the provided driver is not recognized, before op template resolution
Issue : #1006