-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.1 to CI #986
Add Ruby 3.1 to CI #986
Conversation
I haven't committed to |
.github/workflows/test.yml
Outdated
- ruby: '3.0' | ||
gemfile: '5.2' | ||
- ruby: '3.1' | ||
gemfile: '6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Does Rails 6 really not support Ruby 3.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does appear to work 😄
Thanks @petergoldstein 🎉 |
@parndt So it's a question of formal support. Rails 6.0 dropped out of primary support before Ruby 3.1 was released. But either way for these specs is fine - it seems to run ok in most situations (there are some challenges with argument passing in ActionMailer). |
This PR adds Ruby 3.1 to CI.
It also cleans up an unnecessary exclusion for Ruby 3.0 / Rails 5.2 (Rails 5.2 was already removed from the CI matrix).