Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "unknown column" exception #943

Merged

Commits on Jun 6, 2020

  1. Fix "unknown column" exception

    When custom `slug_column` is used along with `history` and
    `sequentially_slugged` modules, wrong query was being formed on `Slug`
    model.
    
    Query being made - `select friendly_id_slugs.strange name from artists`
    Query which should be made - `select friendly_id_slugs.slug from artists`
    
    This commit fixes it to use default `slug` column in such case.
    yogeshjain999 committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    ef20276 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. Split out methods

    A method name with `and` is usually an indicator that it does too much
    parndt committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    c58e3d0 View commit details
    Browse the repository at this point in the history