Add Ruby 3.1 to CI #986
Merged
Add Ruby 3.1 to CI #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't committed to |
parndt
approved these changes
Jan 18, 2022
parndt
reviewed
Jan 18, 2022
.github/workflows/test.yml
Outdated
| - ruby: '3.0' | ||
| gemfile: '5.2' | ||
| - ruby: '3.1' | ||
| gemfile: '6.0' |
There was a problem hiding this comment.
Wow! Does Rails 6 really not support Ruby 3.1?
parndt
reviewed
Jan 18, 2022
|
Thanks @petergoldstein 🎉 |
|
@parndt So it's a question of formal support. Rails 6.0 dropped out of primary support before Ruby 3.1 was released. But either way for these specs is fine - it seems to run ok in most situations (there are some challenges with argument passing in ActionMailer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Ruby 3.1 to CI.
It also cleans up an unnecessary exclusion for Ruby 3.0 / Rails 5.2 (Rails 5.2 was already removed from the CI matrix).