Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compat): remove generatorBundle hook order. #20

Merged
merged 6 commits into from Feb 5, 2023
Merged

Conversation

nonzzz
Copy link
Owner

@nonzzz nonzzz commented Feb 5, 2023

Background

Description

Vite support using object as hooks to change execution order from v3.1.0. vitejs/vite#9634

CheckList

  • Remove hook order.
  • Record bundle meta and compression them in closeBundle stage.
  • Update dynamic test case.

@nonzzz nonzzz added the feature I have a idea label Feb 5, 2023
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #20 (833f649) into master (db64bc1) will decrease coverage by 1.42%.
The diff coverage is 86.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   92.63%   91.21%   -1.42%     
==========================================
  Files           3        3              
  Lines         190      205      +15     
  Branches       34       36       +2     
==========================================
+ Hits          176      187      +11     
- Misses         14       18       +4     
Impacted Files Coverage Δ
src/index.ts 93.38% <86.66%> (-2.49%) ⬇️

@nonzzz nonzzz merged commit 6ea16e4 into master Feb 5, 2023
@nonzzz nonzzz deleted the feat/compat branch February 6, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature I have a idea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant