Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: types of breakpointsBase & effect #7363

Merged

Conversation

Hasan-Mir
Copy link
Contributor

@Hasan-Mir Hasan-Mir commented Mar 11, 2024

This pull request includes updates to the type annotations in swiper-options.d.ts of the Swiper package. The changes are as follows:

  1. effect: The | string part of the type has been removed. This enhances the IntelliSense experience by providing more precise suggestions.

Screenshot 2024-03-11 092210
Screenshot 2024-03-11 092150

  1. breakpointsBase: The type for breakpointsBase has been updated from string to more explicit 'window' | 'container'.

Screenshot 2024-03-11 092104
Screenshot 2024-03-11 092133

@nolimits4web
Copy link
Owner

t0ggles-create swiper

Copy link

t0ggles bot commented Mar 18, 2024

Task nolimits4web/SWIPER-68 was created

t0ggles task SWIPER-68

@nolimits4web
Copy link
Owner

Merged! But kept effect as string for custom effects suppoty

@nolimits4web nolimits4web merged commit a8d7e7c into nolimits4web:master Mar 19, 2024
3 checks passed
Copy link

t0ggles bot commented Mar 19, 2024

Task nolimits4web/SWIPER-68 status changed to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants