Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mapping type to match new mypy #834

Merged
merged 2 commits into from Sep 21, 2021
Merged

Update Mapping type to match new mypy #834

merged 2 commits into from Sep 21, 2021

Conversation

sobolevn
Copy link
Contributor

Hi!

I am working on a new feature in mypy and it identified a problem in your code.
Mapping[str, object] cannot be unpacked into priority: int = 0, lifetime: int = 60, lastseen: Optional[str] = None,, but Mapping[str, Any] can be.

Link: python/mypy#11151

@nolar
Copy link
Owner

nolar commented Sep 20, 2021

Thanks for doing such checks pro-actively (it is an interesting idea!) and for sending this PR.

Please ignore the errors with DeprecationWarning: The loop argument is deprecated … — I am fixing them right now in a separate PR (#828). I will merge this PR as soon as I fix those asyncio issues (maybe a rebase will be needed).

@nolar nolar merged commit fe56b56 into nolar:main Sep 21, 2021
@sobolevn
Copy link
Contributor Author

Thanks a lot for the quick fix! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants