Close dependent http responses before closing api context

[asteven]

Pending aiohttp.ClientResponse instances depend on the aiohttp session stored within a APIContext.

If the APIContext is closed, all responses that depend on in just hang forever or until a configured timeout expires.

Keeping track of aiohttp.ClientResponses and properly closing them if the APIContext itself is closed prevents this from happening. The pending requests are automatically retried instead of left dangling.

We've been using this patch since 10 months in production and have never again seen the errors related to handlers not firing anymore after re-authentication.

closes: #1036

[ron-matsliah]

Hi @nolar, can you please check it out?
It's causing our service to get stuck

[nolar]

Note for self & for future code archaeologists later:

At a first glance, this problem should be already solved by closing the responses in the async with response: … statements in all the get/post/patch methods in kopf/_cogs/clients/api.py. The only exception is streaming, but even there it is closed in the routine the same way; the only difference is that a routine itself is wrapped with a little magic to run in a background.

However, there is another chain of events described in #1036 (comment), which involves catching HTTP 401 from the server and initiating the re-authentication, which implicitly closes the old session BUT without closing the old responses. As such, they get stuck and do not reconnect util kicked/timed out.

This PR introduces a force-stop for those pending connections (likely streaming/watching responses) that are bound to the old 401'ed session.

[nolar]

Thanks for the PR. Released as 1.37.2.