Allow to override User-Agent and Host HTTP headers #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nodemcu#1410 Idea borrowed from (unmerged) nodemcu#1157
|
I need to correct this as it'd undo #1362 I just realized. |
|
I weaved the changes back in but didn't squash the commits so a reviewer can see the difference. |
|
Looks good to me. Welcome back into C land, Marcel :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1410.
docs/en/*.I tested individual requests with and without overridden headers against http://httpbin.org/get.
Side note: it's the first time since I finished uni centuries ago that I wrote C code, something which I then swore I'd never do again. Due to #1168 I find it a pain to edit existing files w/o breaking white spaces (the IDE would fix them for me and I need to revert).