Fix fs.walkStream to properly end async iterators #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Attempting to use
walkStream
's returnedstream.Readable
as an async iterator leads to loops that never complete:What changes did you make? (Give an overview)
Fixed StreamProvider's custom
destroy()
implementation to use thecallback
parameter which is required to correctly finish the stream.Added a
'should support async iteration'
test which demonstrates the issue on master, but works with this change.