fix(fs.walk): do not emit events after destroy

nodelib · Aug 15, 2020 · c0931bf · c0931bf
1 parent 7f48cc8
commit c0931bf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/fs/fs.walk/src/readers/async.spec.ts b/packages/fs/fs.walk/src/readers/async.spec.ts
@@ -53,15 +53,15 @@ describe('Readers → Async', () => {
 			reader.read();
 		});
 
-		it('should do not emit "entry" event after first broken scandir call', (done) => {
+		it('should do not emit events after first broken scandir call', (done) => {
 			const reader = new TestReader('directory');
 
 			const firstFakeDirectoryEntry = tests.buildFakeDirectoryEntry({ name: 'a', path: 'directory/a' });
 			const secondFakeDirectoryEntry = tests.buildFakeDirectoryEntry({ name: 'b', path: 'directory/b' });
 
 			reader.scandir.onFirstCall().yields(null, [firstFakeDirectoryEntry, secondFakeDirectoryEntry]);
-			reader.scandir.onSecondCall().yields(tests.EPERM_ERRNO);
-			reader.scandir.onThirdCall().yields(tests.EPERM_ERRNO);
+			reader.scandir.onSecondCall().yieldsAsync(tests.EPERM_ERRNO);
+			reader.scandir.onThirdCall().yieldsAsync(tests.EPERM_ERRNO);
 
 			/**
 			 * If the behavior is broken, then a third scandir call will trigger an unhandled error.

diff --git a/packages/fs/fs.walk/src/readers/async.ts b/packages/fs/fs.walk/src/readers/async.ts
@@ -87,7 +87,7 @@ export default class AsyncReader extends Reader {
 	}
 
 	private _handleError(error: Error): void {
-		if (!common.isFatalError(this._settings, error)) {
+		if (this._isDestroyed || !common.isFatalError(this._settings, error)) {
 			return;
 		}