Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message in websocket #3250

Closed
wants to merge 1 commit into from

Conversation

KhafraDev
Copy link
Member

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test?

@KhafraDev
Copy link
Member Author

we shouldn't be testing errors until we know the error cases are correct IMO. I confirmed it works locally.

@KhafraDev KhafraDev closed this May 12, 2024
@KhafraDev KhafraDev deleted the fix-websocket-error branch May 12, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants