ci: node nightly test should use node 23 #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
approved these changes
May 12, 2024
There was a problem hiding this comment.
I remember is was done in this way to reduce false positives as we had them in the past, remember @mweberxyz attempted to fix them.
|
Ah, ok. Then lets merge this. |
Merged
kodiakhq bot
pushed a commit
to X-oss-byte/Canary-nextjs
that referenced
this pull request
May 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`6.16.1` -> `6.18.1`](https://renovatebot.com/diffs/npm/undici/6.16.1/6.18.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v6.18.1`](https://togithub.com/nodejs/undici/releases/tag/v6.18.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v6.18.0...v6.18.1) #### What's Changed - docs: Update references to dispatcher in docs by [@​haikyuu](https://togithub.com/haikyuu) in [nodejs/undici#3281 - fix: compatibility for global headers by [@​tsctx](https://togithub.com/tsctx) in [nodejs/undici#3286 - websocket: pre-calculated length by [@​tsctx](https://togithub.com/tsctx) in [nodejs/undici#3284 - ci: fix autobahn workflow by [@​Uzlopak](https://togithub.com/Uzlopak) in [nodejs/undici#3291 - revert: "websocket: pre-calculated length" by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3290 - websocket: use FixedQueue instead of Set by [@​tsctx](https://togithub.com/tsctx) in [nodejs/undici#3283 #### New Contributors - [@​haikyuu](https://togithub.com/haikyuu) made their first contribution in [nodejs/undici#3281 **Full Changelog**: nodejs/undici@v6.18.0...v6.18.1 ### [`v6.18.0`](https://togithub.com/nodejs/undici/releases/tag/v6.18.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v6.17.0...v6.18.0) #### What's Changed - permessage-deflate decompression support in websocket by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3263 - fix: Fix server closing in tests. by [@​ShogunPanda](https://togithub.com/ShogunPanda) in [nodejs/undici#3279 **Full Changelog**: nodejs/undici@v6.17.0...v6.18.0 ### [`v6.17.0`](https://togithub.com/nodejs/undici/releases/tag/v6.17.0) [Compare Source](https://togithub.com/nodejs/undici/compare/v6.16.1...v6.17.0) #### What's Changed - fetch: fix captureStackTrace by [@​Uzlopak](https://togithub.com/Uzlopak) in [nodejs/undici#3227 - fetch: fix wpt test request-upload.any.js by [@​Uzlopak](https://togithub.com/Uzlopak) in [nodejs/undici#3234 - websocket: don't clone buffer by [@​tsctx](https://togithub.com/tsctx) in [nodejs/undici#3240 - Remove unecessary async from writeBuffer by [@​DarkGL](https://togithub.com/DarkGL) in [nodejs/undici#3245 - refactor websocket control frame handling by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3241 - fix parsing continuation frames in websocket by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3247 - ci: node nightly test should use node 23 by [@​Uzlopak](https://togithub.com/Uzlopak) in [nodejs/undici#3248 - Add test to verify if the connection is correctly aborted on cancel by [@​mcollina](https://togithub.com/mcollina) in [nodejs/undici#3219 - Autobahn suite by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3251 - websocket: fix 6 autobahn tests by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3254 - websocket: checkout correct commit in autobahn workflow by [@​Uzlopak](https://togithub.com/Uzlopak) in [nodejs/undici#3258 - Cleanup websocket by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3257 - websocket: autobahn workflow should fail on error by [@​Uzlopak](https://togithub.com/Uzlopak) in [nodejs/undici#3259 - add bodymixin bytes by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3262 - perf: avoid buffer cloning by [@​tsctx](https://togithub.com/tsctx) in [nodejs/undici#3264 - feat: dump interceptor by [@​metcoder95](https://togithub.com/metcoder95) in [nodejs/undici#3118 - use private properties in Headers by [@​KhafraDev](https://togithub.com/KhafraDev) in [nodejs/undici#3269 - Revert "websocket: autobahn workflow should fail on error" by [@​Uzlopak](https://togithub.com/Uzlopak) in [nodejs/undici#3270 - build(deps): bump node from `487dc5d` to `9e8f45f` in /build by [@​dependabot](https://togithub.com/dependabot) in [nodejs/undici#3271 #### New Contributors - [@​DarkGL](https://togithub.com/DarkGL) made their first contribution in [nodejs/undici#3245 **Full Changelog**: nodejs/undici@v6.16.1...v6.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today again i got an email that our nightly fails. checked it and wondered why node nightly from 24 april was used. checked the node page and saw, that since we have node 23, no node 22 nightlies are published. So we have to change the target.
Also here I wonder if the following condition is correct:
undici/.github/workflows/nightly.yml
Line 37 in 38c8b55
I would actually say, that it should be or conditions and not and conditions. If the tests fail in windows but mac and linux pass, as it is now, then we dont get an issue created. Rn i still get an email that it failed.
Maybe @mweberxyz share his opinion?
Maybe can be taken care in a follow up.