refactor websocket control frame handling #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhafraDev
force-pushed
the
refactor-websocket-control-frame-handling
branch
from
67ee2d2
to
f7a4534
Compare
Co-authored-by: tai-kun <taikun.dev@gmail.com>
KhafraDev
force-pushed
the
refactor-websocket-control-frame-handling
branch
from
f7a4534
to
b5e4452
Compare
7 tasks
|
@nodejs/undici |
tsctx
approved these changes
May 11, 2024
|
thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3239
Closes #2859
Control frames cannot be fragmented which guarantees that they will be handled in full in a single message. Since this is the case, there's no reason to assign values to
this.#info(which is the internal state/settings of a frame) which should avoid race conditions.