dup-keys-non-strings #3166
Open
dup-keys-non-strings #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James1x0 <james@twox.io>
|
I think duplicate headers are allowed by the spec |
|
Actually not sure what is correct here. |
|
@ronag I think duplicates are only list values? |
Co-authored-by: James1x0 <james@twox.io>
|
based on https://www.rfc-editor.org/rfc/rfc9110.html#name-field-lines-and-combined-fi seems like keys CAN be duplicates as long as the values are an array. If i am understanding this correct, commit # 698e64e should fix this. |
|
The actual commit still seems to have the implementation that throws on duplicate, can we verify we change it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #1902
Rationale
now throws an error if the headers key is not a string or duplicated
Changes
Breaking Changes and Deprecations
Not sure, but this will block ALL requests that have headers which are not of type 'String' or are duplicated.
Status