feat: new hooks API #3051
Closed
feat: new hooks API #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
new-hooks
branch
9 times, most recently
from
0995e6e
to
c0d31c0
Compare
ShogunPanda
requested changes
Apr 4, 2024
ShogunPanda
reviewed
Apr 4, 2024
types/dispatcher.d.ts
Outdated
| /** Invoked before response is starting to be processed */ | ||
| onResponseStart?(): void; | ||
| /** Invoked after status headers data has been received */ | ||
| onResponseHeaders?(headers: Array<Buffer|string>, statusCode: number, statusText: string): void; |
There was a problem hiding this comment.
Nit: remember that technically the statusText is optional. So it should be statusText?: string.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3051 +/- ##
==========================================
- Coverage 93.51% 93.42% -0.09%
==========================================
Files 89 89
Lines 24331 24505 +174
==========================================
+ Hits 22754 22895 +141
- Misses 1577 1610 +33 ☔ View full report in Codecov by Sentry. |
ronag
force-pushed
the
new-hooks
branch
7 times, most recently
from
705a0d3
to
d4fb661
Compare
ronag
force-pushed
the
new-hooks
branch
2 times, most recently
from
0302417
to
b7738a3
Compare
ronag
force-pushed
the
new-hooks
branch
5 times, most recently
from
ae67989
to
8b139ff
Compare
|
Closing in favour of simpler and less complete version. #3054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status