New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dns cache #2440 #2552
Open
antoinegomez
wants to merge
21
commits into
nodejs:main
Choose a base branch
from
antoinegomez:feat-add-dns-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
9413807
feat: add dns cache #2440
antoinegomez 5170763
refactor
antoinegomez 65cc4fc
use whole cacheable-dns module instead, use it in Agent and Pool
antoinegomez dffb510
use Promise.allSettled
antoinegomez d28dc26
Merge branch 'main' into feat-add-dns-cache
antoinegomez 0b0ca32
fix ipv6
antoinegomez 9a8ea6e
slight refactor
antoinegomez 14e986b
add tests
antoinegomez 007872f
apply comments
antoinegomez 7940b9a
add documentation and global
antoinegomez 3db9550
remove global dns resolver
antoinegomez afd92c8
resolve comments
antoinegomez 30ef32b
test agent DNSResolver disabled
antoinegomez 67c132f
Update lib/agent.js
antoinegomez 4f603a6
Update lib/dns-resolver.js
antoinegomez 3c4487b
Update lib/pool.js
antoinegomez b192a0e
update comments
antoinegomez bbff8e2
add types
antoinegomez 13616d3
fix comments
antoinegomez 76e34bb
add types
antoinegomez 8ee39e8
Merge branch 'main' into feat-add-dns-cache
antoinegomez File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only throw the first error? Wouldn't it be better to throw an AggregateError that contains both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing that, using AggregateError and modifying tests