Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): responseHeaders typo in type #2317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vickvu
Copy link

@vickvu vickvu commented Oct 7, 2023

This relates to...

N/A

Rationale

The name of the field should be responseHeaders

Changes

Change the field name to responseHeaders

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (4601498) 85.43%.
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   85.54%   85.43%   -0.12%     
==========================================
  Files          76       76              
  Lines        6858     6866       +8     
==========================================
- Hits         5867     5866       -1     
- Misses        991     1000       +9     
Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
lib/core/connect.js 80.00% <100.00%> (-1.25%) ⬇️
lib/fetch/body.js 97.67% <100.00%> (-0.02%) ⬇️
lib/fetch/global.js 100.00% <ø> (ø)
lib/fetch/index.js 85.20% <100.00%> (ø)
lib/pool.js 100.00% <100.00%> (ø)
lib/websocket/connection.js 89.15% <100.00%> (+0.13%) ⬆️
lib/websocket/frame.js 100.00% <100.00%> (ø)
lib/client.js 93.07% <92.30%> (-0.05%) ⬇️
lib/core/util.js 92.63% <85.71%> (-3.16%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this? We use tsd to verify our types.

@kibertoad
Copy link
Contributor

@vickvu Do you need help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants