Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt: add FormData wpts #1722

Merged
merged 2 commits into from Oct 22, 2022
Merged

wpt: add FormData wpts #1722

merged 2 commits into from Oct 22, 2022

Conversation

KhafraDev
Copy link
Member

Fixes 2 issues in FormData:

  • new FormData(null) should throw
  • have File entries inherit the lastModified property

These tests only take ~330 ms to run.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Base: 89.55% // Head: 89.53% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (71fabcf) compared to base (3f9d694).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
- Coverage   89.55%   89.53%   -0.02%     
==========================================
  Files          58       58              
  Lines        5257     5258       +1     
==========================================
  Hits         4708     4708              
- Misses        549      550       +1     
Impacted Files Coverage Δ
lib/fetch/formdata.js 96.00% <100.00%> (+0.04%) ⬆️
lib/fetch/file.js 90.00% <0.00%> (-1.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 54437e2 into nodejs:main Oct 22, 2022
@KhafraDev KhafraDev deleted the formdata-wpts branch October 22, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants