Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update llhttp to the latest version v8.1.0 #1718

Merged
merged 3 commits into from Oct 25, 2022

Conversation

HassanBahati
Copy link
Contributor

@HassanBahati HassanBahati commented Oct 19, 2022

This pr addresses #1710

@HassanBahati
Copy link
Contributor Author

@mcollina please review

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 89.53% // Head: 89.55% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (caef2cd) compared to base (7102eb0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
+ Coverage   89.53%   89.55%   +0.01%     
==========================================
  Files          58       58              
  Lines        5257     5257              
==========================================
+ Hits         4707     4708       +1     
+ Misses        550      549       -1     
Impacted Files Coverage Δ
lib/llhttp/llhttp.wasm.js 100.00% <ø> (ø)
lib/llhttp/llhttp_simd.wasm.js 100.00% <ø> (ø)
lib/fetch/file.js 91.00% <0.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcollina
Copy link
Member

Please update the llhttp wasm bundle

@HassanBahati
Copy link
Contributor Author

Okay please, let me do so

@HassanBahati
Copy link
Contributor Author

Please update the llhttp wasm bundle

@mcollina , I've tried with different versions of Node.js and also tried various solutions online, but this error hinders me from updating the llhttp wasm bundle when i run npm run prebuild:wasm

Even with the latest version v19.0.0 of Node.js , still unable to successfully run npm run prebuild:wasm

Screenshot from 2022-10-20 20-50-01

@mcollina
Copy link
Member

You have a broken node/npm installation. You have likely installed node via brew/apt/* at some time and never removed it. On top, the nvm paths are misconfigured.

@HassanBahati
Copy link
Contributor Author

@mcollina thank you for the feedback, on reinstalling node.js all worked fine. I have updated the wasm bundle

@mcollina
Copy link
Member

Please run npx standard --fix to adjust linting.

@HassanBahati
Copy link
Contributor Author

Okay please, let me do so

@HassanBahati
Copy link
Contributor Author

@mcollina i fixed the linting

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6a20cb4 into nodejs:main Oct 25, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* update deps/llhttp/includes and deps/lhttp/src to v8.1.0

* update the llhttp wasm bundle

* ran npx standard --fix to adjust linting
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* update deps/llhttp/includes and deps/lhttp/src to v8.1.0

* update the llhttp wasm bundle

* ran npx standard --fix to adjust linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants