Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt: run tests in parallel (2.5x speed improvement) #1714

Merged
merged 1 commit into from Oct 18, 2022

Conversation

KhafraDev
Copy link
Member

Before:

> time npm run test:wpt

[fetch]: Completed: 1283, failed: 140, success: 1143, expected failures: 140, unexpected failures: 0
[FileAPI]: Completed: 234, failed: 19, success: 215, expected failures: 19, unexpected failures: 0
[mimesniff]: Completed: 1898, failed: 1008, success: 890, expected failures: 1008, unexpected failures: 0

real    0m26.233s
user    0m12.328s
sys     0m4.500s

After:

> time npm run test:wpt

[fetch]: Completed: 1283, failed: 140, success: 1143, expected failures: 140, unexpected failures: 0
[FileAPI]: Completed: 234, failed: 19, success: 215, expected failures: 19, unexpected failures: 0
[mimesniff]: Completed: 1898, failed: 1008, success: 890, expected failures: 1008, unexpected failures: 0

real    0m10.181s
user    0m13.641s
sys     0m8.031s

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 89.55% // Head: 89.55% // No change to project coverage 👍

Coverage data is based on head (50ed1c8) compared to base (dfee69f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1714   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files          58       58           
  Lines        5257     5257           
=======================================
  Hits         4708     4708           
  Misses        549      549           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev KhafraDev merged commit 7102eb0 into nodejs:main Oct 18, 2022
@KhafraDev KhafraDev deleted the run-tests-in-parallel branch October 18, 2022 21:46
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants