Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt: add remaining fetch/api/basic tests #1708

Merged
merged 7 commits into from Oct 17, 2022

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Oct 17, 2022

Fixes a few bugs and changes some things.

  • Fetching about:blank now throws an error. Even though it's in the spec, no other platform supports fetching about:blank.
  • Serializes request/response's url getter.
  • Fixes an issue in the url serializer.
  • Fixes an issue in the integrity handler where it would pick weaker hashing algorithms when there was a stronger one present.
  • Fixes an issue where the integrity match regex was too strict.

Also undici now passes over 1,000 fetch WPTs

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 94.19% // Head: 94.24% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (b730ce3) compared to base (3bda21f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
+ Coverage   94.19%   94.24%   +0.05%     
==========================================
  Files          53       53              
  Lines        4957     4955       -2     
==========================================
+ Hits         4669     4670       +1     
+ Misses        288      285       -3     
Impacted Files Coverage Δ
lib/fetch/dataURL.js 88.67% <100.00%> (+0.62%) ⬆️
lib/fetch/index.js 83.23% <100.00%> (-0.13%) ⬇️
lib/fetch/request.js 84.82% <100.00%> (+0.05%) ⬆️
lib/fetch/response.js 95.58% <100.00%> (+1.07%) ⬆️
lib/fetch/util.js 85.30% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronag ronag merged commit f2e18aa into nodejs:main Oct 17, 2022
@KhafraDev KhafraDev deleted the add-even-more-wpts branch October 17, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants