Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt: add scheme-blob.sub.any.js #1707

Merged
merged 1 commit into from Oct 16, 2022

Conversation

KhafraDev
Copy link
Member

  • Adds in the ability for the WPT runner to handle pipes/subs.
  • Adds in scheme-blob.sub.any.js test to ensure this works (file names with .sub in them have substitutions in them).

Two tests fail out of 17. One of the tests is entirely... wrong/broken, and the other is illogical. We pass more tests than Chrome/Firefox and the same 2 tests fail on Safari (see: results).

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 94.19% // Head: 94.19% // No change to project coverage 👍

Coverage data is based on head (1309e31) compared to base (2787b64).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1707   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files          53       53           
  Lines        4957     4957           
=======================================
  Hits         4669     4669           
  Misses        288      288           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronag ronag merged commit 3bda21f into nodejs:main Oct 16, 2022
@ronag
Copy link
Member

ronag commented Oct 16, 2022

Do the WPT test contribute to the coverage?

@KhafraDev KhafraDev deleted the wpt-handle-pipes-and-subs branch October 16, 2022 14:36
@KhafraDev
Copy link
Member Author

no, but it would be great if they did.

@KhafraDev
Copy link
Member Author

I'm guessing it's not possible, maybe because of workers?

> undici@5.11.0 test:wpt
> node scripts/verifyVersion 18 || (node test/wpt/start-fetch.mjs && node test/wpt/start-FileAPI.mjs && node test/wpt/start-mimesniff.mjs)

[fetch]: Completed: 985, failed: 20, success: 965, expected failures: 20, unexpected failures: 0
[FileAPI]: Completed: 95, failed: 1, success: 94, expected failures: 1, unexpected failures: 0
[mimesniff]: Completed: 1898, failed: 1008, success: 890, expected failures: 1008, unexpected failures: 0
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |        0 |        0 |        0 |        0 |                   |
----------|----------|----------|----------|----------|-------------------|

@ronag
Copy link
Member

ronag commented Oct 16, 2022

@mcollina wdyt?

@KhafraDev
Copy link
Member Author

I tried using c8 as well, and although we get some results (not sure if they're accurate) it prevents the worker from exiting. 😕

metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants