Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minesniff WPTs #1702

Merged
merged 1 commit into from Oct 14, 2022
Merged

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Oct 14, 2022

Undici implements a subset of the mimesniff spec for data URLs.

Currently passes 909 tests and fails 989. This might seem pretty bad, but undici currently passes more of these tests than Chrome and Safari (results). There's likely more we can do, but most of the failures are caused by node's mimetype parser (or whatever is used in Blob).

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev KhafraDev merged commit d8ae8e6 into nodejs:main Oct 14, 2022
@KhafraDev KhafraDev deleted the add-mimesniff-wpts branch October 14, 2022 21:34
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants