Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: use structuredClone in clone body steps #1699

Conversation

KhafraDev
Copy link
Member

Refs: nodejs/node#44985

Having the process stay open causes some annoying and unexpected consequences.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 94.08% // Head: 94.05% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e94ac6c) compared to base (4b30d47).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   94.08%   94.05%   -0.04%     
==========================================
  Files          53       53              
  Lines        4923     4912      -11     
==========================================
- Hits         4632     4620      -12     
- Misses        291      292       +1     
Impacted Files Coverage Δ
lib/fetch/constants.js 100.00% <ø> (+3.70%) ⬆️
lib/fetch/body.js 95.79% <100.00%> (-0.02%) ⬇️
lib/core/connect.js 98.27% <0.00%> (-1.73%) ⬇️
lib/fetch/file.js 91.86% <0.00%> (-1.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KhafraDev KhafraDev closed this Oct 13, 2022
@KhafraDev KhafraDev deleted the revert-structuredclone-clone-body-steps branch October 13, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants