Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed typos #1695

Merged
merged 1 commit into from Oct 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmarks/benchmark.js
Expand Up @@ -112,14 +112,14 @@ function printResults (results) {
let last

const rows = Object.entries(results)
// If any failed, put on the top of the list, otherwise order by mean, ascendin
// If any failed, put on the top of the list, otherwise order by mean, ascending
.sort((a, b) => (!a[1].success ? -1 : b[1].mean - a[1].mean))
.map(([name, result]) => {
if (!result.success) {
return [name, result.size, 'Errored', 'N/A', 'N/A']
}

// Calculate throughtput and relative performance
// Calculate throughput and relative performance
const { size, mean, standardError } = result
const relative = last !== 0 ? (last / mean - 1) * 100 : 0

Expand Down
2 changes: 1 addition & 1 deletion benchmarks/server.js
Expand Up @@ -16,7 +16,7 @@ if (cluster.isPrimary) {
try {
unlinkSync(socketPath)
} catch (_) {
// Do not nothing if the socket does not exist
// Do nothing if the socket does not exist
}

for (let i = 0; i < workers; i++) {
Expand Down
2 changes: 1 addition & 1 deletion lib/api/api-stream.js
Expand Up @@ -106,7 +106,7 @@ class StreamHandler extends AsyncResource {
}

res.on('drain', resume)
// TODO: Avoid finished. It registers an unecessary amount of listeners.
// TODO: Avoid finished. It registers an unnecessary amount of listeners.
finished(res, { readable: false }, (err) => {
const { callback, res, opaque, trailers, abort } = this

Expand Down