feat(WPTs): add in idlharness.any.js test #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was painful.
Codecov ReportBase: 94.05% // Head: 94.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
- Coverage 94.05% 94.02% -0.04%
==========================================
Files 53 53
Lines 4897 4904 +7
==========================================
+ Hits 4606 4611 +5
- Misses 291 293 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
where can we find that stats about compliance of our version vs others? |
ronag
approved these changes
Oct 7, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
this was painful.
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
this was painful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ~20 'bugs' in fetch. Note that every change was done for a reason and I could explain why if you'd like.
1 failed test. I could easily fix it but the test itself makes no sense (
Response.json.lengthshould be 0). This test also fails in chrome and Deno (only other environments that implement Response.json that I bothered checking).However node now passes more of fetch's idlharness tests than any other platform, so that's cool.